[PATCH] D64384: [WIP] Index-while-building

Wed Aug 21 18:10:54 PDT 2019

jkorous marked an inline comment as done.
jkorous added inline comments.

================
Comment at: clang/include/clang/Frontend/FrontendOptions.h:391
+  std::string IndexStorePath;
+  unsigned IndexIgnoreSystemSymbols : 1;
+  unsigned IndexRecordCodegenName : 1;
----------------
gribozavr wrote:
> Could we change "ignore system symbols" into a positive option ("record system symbols")? Throughout the patch please.
Surprisingly it seems that the name is actually mostly determined by the fact that we want to index system symbols by default and that natural CLI for boolean argument with default positive value is optional flag with negative semantics.

Specifically - the semantics/name of the flag `OPT_index_ignore_system_symbols` is pretty much given (or ?).

I could rename just `IndexIgnoreSystemSymbols ` and keep `OPT_index_ignore_system_symbols` but it feels less clear than current state.

WDYT?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64384/new/

https://reviews.llvm.org/D64384