[PATCH] D64384: [WIP] Index-while-building

Jan Korous via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 17:32:10 PDT 2019


jkorous marked 3 inline comments as done.
jkorous added inline comments.


================
Comment at: clang/include/clang/Frontend/CompilerInstance.h:810
+    return GenModuleActionWrapper;
+  }
+
----------------
jkorous wrote:
> gribozavr wrote:
> > I don't see anything actually using `GenModuleActionWrapper`.
> IIUC it's both used (lambda on CompilerInstance.cpp:L1136) and passed (CompilerInstance.cpp:L1112) to `CompilerInstance` of module dependencies in `compileModuleImpl`.
I was wrong! I thought we are passing some data in the wrapper. Turned out we aren't and I was able to completely remove it. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64384/new/

https://reviews.llvm.org/D64384





More information about the llvm-commits mailing list