[PATCH] D66097: Handle local commons for XCOFF object file writing

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:238
+      assert(XCOFF::XTY_CM == MCSec->getCSectType() &&
+             "Mapping invalid csect. Csect with bss storage class must be "
+             "common type.");
----------------
hubert.reinterpretcast wrote:
> "CSect" would match how the function is named.
I guess it's "CSECT" now.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:240
+             "common type.");
+      Add(&BSS, BSSCSects, MCSec);
+      break;
----------------
There's no `Add` in the base patch anymore. This needs a rebase.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-lcomm.ll:5
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s
+; RUN: llvm-readobj --section-headers --file-header %t.o | \
+; RUN: FileCheck --check-prefix=OBJ %s
----------------
hubert.reinterpretcast wrote:
> There should be a follow-up patch to this (dependent on D65240) that checks the symbol table entries.
D65240 might land before this, in which case, this patch should be updated for the test changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66097/new/

https://reviews.llvm.org/D66097