[llvm] r369598 - [X86] Replace a couple hardcoded '5's with X86::AddrNumOperands for readability. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 15:40:08 PDT 2019


Author: ctopper
Date: Wed Aug 21 15:40:07 2019
New Revision: 369598

URL: http://llvm.org/viewvc/llvm-project?rev=369598&view=rev
Log:
[X86] Replace a couple hardcoded '5's with X86::AddrNumOperands for readability. NFC

Modified:
    llvm/trunk/lib/Target/X86/X86ExpandPseudo.cpp

Modified: llvm/trunk/lib/Target/X86/X86ExpandPseudo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ExpandPseudo.cpp?rev=369598&r1=369597&r2=369598&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ExpandPseudo.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ExpandPseudo.cpp Wed Aug 21 15:40:07 2019
@@ -194,7 +194,8 @@ bool X86ExpandPseudo::ExpandMI(MachineBa
   case X86::TCRETURNmi64: {
     bool isMem = Opcode == X86::TCRETURNmi || Opcode == X86::TCRETURNmi64;
     MachineOperand &JumpTarget = MBBI->getOperand(0);
-    MachineOperand &StackAdjust = MBBI->getOperand(isMem ? 5 : 1);
+    MachineOperand &StackAdjust = MBBI->getOperand(isMem ? X86::AddrNumOperands
+                                                         : 1);
     assert(StackAdjust.isImm() && "Expecting immediate value.");
 
     // Adjust stack pointer.
@@ -259,7 +260,7 @@ bool X86ExpandPseudo::ExpandMI(MachineBa
                         ? X86::TAILJMPm
                         : (IsWin64 ? X86::TAILJMPm64_REX : X86::TAILJMPm64);
       MachineInstrBuilder MIB = BuildMI(MBB, MBBI, DL, TII->get(Op));
-      for (unsigned i = 0; i != 5; ++i)
+      for (unsigned i = 0; i != X86::AddrNumOperands; ++i)
         MIB.add(MBBI->getOperand(i));
     } else if (Opcode == X86::TCRETURNri64) {
       JumpTarget.setIsKill();




More information about the llvm-commits mailing list