[PATCH] D65697: [lit] Fix internal env calling env

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D65697#1639974 <https://reviews.llvm.org/D65697#1639974>, @rnk wrote:

> Based on what Paul said, it seems that we have some clang/LLVM tests that use internal diff and some that use real external diff in a pipeline, and we didn't know it.


The tests using an external diff in a pipeline are necessarily within test suites that never use lit's internal diff because the test suites are configured not to use lit's internal shell, right?  (That is assuming buggy cases like `env` or `not` calling diff don't come into play.)

> Anyway, this patch is good to go, IMO.

Thanks again.  I'll try to push soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65697/new/

https://reviews.llvm.org/D65697