[PATCH] D66407: [llvm-objcopy][MachO] Implement -Ibinary

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

LGTM



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-input.test:1
+# Show that if -I binary is given, llvm-objopy creates a Mach-O object which
+# contains the input file contents.
----------------
llvm-objcopy


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-input.test:4
+
+RUN: not llvm-objcopy -Ibinary -B x86-64 -Omach-o-x86-64 %t.nonexistent %t.o.nonexistent 2>&1 \
+RUN:   | FileCheck %s -DINPUT=%t.nonexistent --check-prefix=NONEXSITENT-FILE
----------------
Per the other patch, these should use `-B i386:x86-64` as the main supported config


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-input.test:40
+CHECK-NEXT:    Symbol {
+CHECK-NEXT:      Name: __binary_{{[_a-zA-Z0-9]*}}_size
+CHECK-NEXT:      Extern
----------------
I believe you should be able to check for `.input` to appear in these strings as `_input` too, e.g. `__binary_{{[_a-zA-Z0-9]*}}_input_size`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66407/new/

https://reviews.llvm.org/D66407