[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c

Wed Aug 21 11:45:41 PDT 2019

rupprecht added a comment.

I think this patch is causing BB errors:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/13605/steps/build%20stage1%20clang/logs/stdio

  FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o 
  /usr/bin/cc  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Support -I/usr/include/libxml2 -Iinclude -I/b/sanitizer-x86_64-linux-bootstrap/build/llvm/include -fPIC -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -O3    -UNDEBUG -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o   -c /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Support/regcomp.c
  In file included from /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Support/regcomp.c:51:0:
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:152:30: error: missing ')' after "__has_attribute"
   #if __has_cpp_attribute(clang::reinitializes)
                                ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:152:31: error:  ':' without preceding '?'
   #if __has_cpp_attribute(clang::reinitializes)
                                 ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:255:30: error: missing ')' after "__has_attribute"
   #elif __has_cpp_attribute(gnu::fallthrough)
                                ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:255:31: error:  ':' without preceding '?'
   #elif __has_cpp_attribute(gnu::fallthrough)
                                 ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:259:32: error: missing ')' after "__has_attribute"
   #elif __has_cpp_attribute(clang::fallthrough)
                                  ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:259:33: error:  ':' without preceding '?'
   #elif __has_cpp_attribute(clang::fallthrough)
                                   ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:267:30: error: missing ')' after "__has_attribute"
   #if __has_cpp_attribute(clang::require_constant_initialization)
                                ^
  /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Support/Compiler.h:267:31: error:  ':' without preceding '?'
   #if __has_cpp_attribute(clang::require_constant_initialization)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66487/new/

https://reviews.llvm.org/D66487