[PATCH] D66545: [WebAssembly] Add Emscripten support for UBSan, LSan and ASan

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp:21
+#if SANITIZER_EMSCRIPTEN
+extern "C" void emscripten_builtin_free(void *);
+#include <emscripten/em_asm.h>
----------------
sbc100 wrote:
> Perhaps worth putting these `emscripten_builtin_` functions in the header file and then `#include <emscripten/foo.h>` here and elsewhere rather than forward declaring them?
Same with `emscripten_get_module_name`.. they could maybe go in `<emscripten/internal.h>` for want of a better name?  Or maybe <emscripoten/jsapi.h>`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66545/new/

https://reviews.llvm.org/D66545