[PATCH] D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 07:55:47 PDT 2019


deadalnix created this revision.
deadalnix added reviewers: craig.topper, efriedma, RKSimon, lebedev.ri.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This comes as a first step toward processing the DAG nodes in topological orders. Doing so ensure that arguments of a node are combined before the node itself is combined, which exposes ore opportunities for optimization and/or reduce the amount of patterns a node has to match for.

DAGCombiner adding nodes to the worklist is various places causes the nodes to be in a different order from what is expected. In addition, this is reduant because these nodes end up being added to the worklist anyways due to the machinery at line 1621.


Repository:
  rL LLVM

https://reviews.llvm.org/D66537

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66537.216402.patch
Type: text/x-patch
Size: 26882 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190821/be56c1de/attachment.bin>


More information about the llvm-commits mailing list