[PATCH] D63676: Early exit from Hoist() in machine licm pass based on block hotness

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 06:27:23 PDT 2019


Whitney added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:53
 #include <vector>
+#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
 
----------------
Please run clang-format on your change. The include is not added at the right place.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1585
+  if (Ratio > BlockFrequencyRatioThreshold) {
+    NumNotHoistedDueToHotness++;
+    return true;
----------------
Change to `++ NumNotHoistedDueToHotness`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676





More information about the llvm-commits mailing list