[PATCH] D66521: [llvm-readobj] - Remove `reportError(std::error_code EC, StringRef Input)` helper.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 03:14:04 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht.
Herald added a subscriber: seiya.

We do not need it, `std::error_code` is used mostly for COFF and
this patch rewrites the calls to use a different overload.

Having `reportError(std::error_code EC, ...` is excessive by itself,
because API that use error codes actually needs refactoring to
use Error/Expected<> instead.


https://reviews.llvm.org/D66521

Files:
  tools/llvm-readobj/COFFDumper.cpp
  tools/llvm-readobj/ELFDumper.cpp
  tools/llvm-readobj/llvm-readobj.cpp
  tools/llvm-readobj/llvm-readobj.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66521.216362.patch
Type: text/x-patch
Size: 17670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190821/ebd60491/attachment.bin>


More information about the llvm-commits mailing list