[PATCH] D65242: [ELF] More dynamic relocation packing

Wed Aug 21 02:05:59 PDT 2019

MaskRay added a comment.

In D65242#1638832 <https://reviews.llvm.org/D65242#1638832>, @victoryang wrote:

> In D65242#1638828 <https://reviews.llvm.org/D65242#1638828>, @MaskRay wrote:
>
> > In D65242#1638801 <https://reviews.llvm.org/D65242#1638801>, @victoryang wrote:
> >
> > > Could this be due to merge conflict in the test case?
> >
> >
> > No. You can apply the reverse of rL369497 <https://reviews.llvm.org/rL369497>. There is no merge conflict.
>
>
> Reading the error message again, it seems to me that grouping isn't happening for bar2 on ANDROID32. Given that we have
>
>   if (j - i < 3 || i->r_addend != 0)
>
>
> I wonder if r_addend isn't always 0 or isn't initialized when RELA is not used?

Ah.. It is not initialized.. I know how to fix it then

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65242/new/

https://reviews.llvm.org/D65242