[PATCH] D66495: [MemorySSA] Fix existing phis when inserting defs.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:355
+        // Existing Phis in IDF may need fixing as well, and potentially be
+        // trivial before this insertion, hence add all IDF Phis.
+        NonOptPhis.insert(MPhi);
----------------
this is somewhat surprising to me, so please add to this comment some kind of pointer to PR43044 and/or test/Analysis/MemorySSA/PR43044.ll. that way, understanding why this happens is a bit easier for future interested parties :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66495/new/

https://reviews.llvm.org/D66495