[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Support/Compiler.h:530
 
+#if __cplusplus
 namespace llvm {
----------------
aaron.ballman wrote:
> `#if defined(__cplusplus)` here as well.
is `#ifdef __cplusplus` against a style guide? Usually I only use `defined` if there's more than one symbol to check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66487/new/

https://reviews.llvm.org/D66487