[llvm] r368339 - [MBP] Disable aggressive loop rotate in plain mode

[Carrot Wei via llvm-commits]

Jeremy, thanks for taking care of it.

On Tue, Aug 20, 2019 at 1:06 AM Jeremy Morse
<jeremy.morse.llvm at gmail.com> wrote:
>
> Hi,
>
> On Mon, Aug 19, 2019 at 11:58 PM Carrot Wei <carrot at google.com> wrote:
> > There are following code in function LiveDebugValues::transferSpillOrRestoreInst,
> >
> >  854     } else if (TKind == TransferKind::TransferRestore &&
> >  855                VarLocIDs[ID].Loc.SpillLocation == *Loc) {
> >  856       LLVM_DEBUG(dbgs() << "Restoring Register " << printReg(Reg,
> > TRI) << '('
> >  857                         << VarLocIDs[ID].Var.getVar()->getName() << ")\n");
> >
> > There is no checking of VarLocIDs[ID].Kind before the usage of
> > VarLocIDs[ID].Loc.SpillLocation, is this another bug?
>
> Yes it is :(, thanks for bringing that up, I'll take care of getting that in.
>
> --
> Thanks,
> Jeremy