[llvm] r369391 - [llvm-objcopy] Append '\n' to warning messages

[Fangrui Song via llvm-commits]

Author: maskray
Date: Tue Aug 20 08:00:07 2019
New Revision: 369391

URL: http://llvm.org/viewvc/llvm-project?rev=369391&view=rev
Log:
[llvm-objcopy] Append '\n' to warning messages

Currently the warning message of `llvm-strip %t.o %t.o` does not include
the trailing newline. Fix this by appending a '\n'.

This is the only warning llvm-objcopy and llvm-strip can issue.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D66475

Modified:
    llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test
    llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp

Modified: llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test?rev=369391&r1=369390&r2=369391&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test (original)
+++ llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test Tue Aug 20 08:00:07 2019
@@ -9,10 +9,11 @@
 
 # ERR: error: cannot specify '-' as an input file more than once
 
-# RUN: llvm-strip %t %t 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t
-# RUN: llvm-strip %t %t %t 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t
+# RUN: cp %t %t2
+# RUN: llvm-strip %t %t %t %t2 %t2 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t -DFILE2=%t2
 
-# WARN: warning: '[[FILE]]' was already specified
+# WARN:      warning: '[[FILE]]' was already specified
+# WARN-NEXT: warning: '[[FILE2]]' was already specified
 
 --- !ELF
 FileHeader:

Modified: llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp?rev=369391&r1=369390&r2=369391&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp Tue Aug 20 08:00:07 2019
@@ -84,7 +84,7 @@ LLVM_ATTRIBUTE_NORETURN void reportError
 
 ErrorSuccess reportWarning(Error E) {
   assert(E);
-  WithColor::warning(errs(), ToolName) << toString(std::move(E));
+  WithColor::warning(errs(), ToolName) << toString(std::move(E)) << '\n';
   return Error::success();
 }