[PATCH] D66464: Regex: +regex string lifetime comment

[Jan Kratochvil via Phabricator via llvm-commits]

jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.


================
Comment at: llvm/include/llvm/Support/Regex.h:48
+    ///
+    /// \param Regex - referenced string lifetime is no longer needed after this
+    /// constructor does finish.  Only its compiled form is kept stored.
----------------
labath wrote:
> I don't think you need the *lifetime* of that string -- you need the string itself. :) Just drop that word, and this will be fine.
The **lifetime** keyword was there to highlight the main point of that statement. But I agree it should be clear enough even without it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66464/new/

https://reviews.llvm.org/D66464