[PATCH] D66408: [llvm-objcopy][MachO] Implement --dump-section

[Seiya Nuta via Phabricator via llvm-commits]

seiya added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/dump-section.test:64
+        reserved2:       0x00000000
+        reserved3:       0x00000000
+      - sectname:        __data
----------------
MaskRay wrote:
> It seems `reserved3` is optional but `reserved[12]` are not:
> 
> ```
> // lib/ObjectYAML/MachOYAML.cpp#L279
>   IO.mapRequired("reserved1", Section.reserved1);
>   IO.mapRequired("reserved2", Section.reserved2);
>   IO.mapOptional("reserved3", Section.reserved3);
> ```
> 
> If some field are not significant in the test, they can be deleted.
Oh I didn't noticed that. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66408/new/

https://reviews.llvm.org/D66408