[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 216111.
jdenny set the repository for this revision to rG LLVM Github Monorepo.
jdenny added a comment.

- Rebased.
- Renamed `%TestFileCheckOut` to `%ProtectFileCheckOutput`.
- Added documentation to `llvm/docs/TestingGuide.rst`.

This patch isn't ready to be pushed yet.  FileCheck's test suite doesn't use lit's internal shell, and this patch introduces calls to `env -u`, which D65335 <https://reviews.llvm.org/D65335> explains is not portable across external `env` implementations.  One solution is to remove the use of `env -u` here.  Another solution is to change FileCheck's test suite to use lit's internal shell.  The latter solution is probably generally better for portability, but it won't help this patch without the patches I'm working on for lit's internal shell in order to push D65156 <https://reviews.llvm.org/D65156> again.  I'm inclined to wait on that anyway to be sure we've actually fully understood the trouble there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121

Files:
  llvm/test/FileCheck/check-count.txt
  llvm/test/FileCheck/check-empty-tag.txt
  llvm/test/FileCheck/check-empty.txt
  llvm/test/FileCheck/check-label-dag.txt
  llvm/test/FileCheck/check-label.txt
  llvm/test/FileCheck/check-multiple-prefixes-nomatch-2.txt
  llvm/test/FileCheck/check-multiple-prefixes-nomatch.txt
  llvm/test/FileCheck/check-not-diaginfo.txt
  llvm/test/FileCheck/check-prefixes.txt
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/dump-input-enable.txt
  llvm/test/FileCheck/envvar-opts.txt
  llvm/test/FileCheck/implicit-check-not.txt
  llvm/test/FileCheck/line-count.txt
  llvm/test/FileCheck/lit.local.cfg
  llvm/test/FileCheck/match-full-lines.txt
  llvm/test/FileCheck/multiple-missing-prefixes.txt
  llvm/test/FileCheck/no-check-file.txt
  llvm/test/FileCheck/no-multi-suffixes.txt
  llvm/test/FileCheck/numeric-defines-diagnostics.txt
  llvm/test/FileCheck/numeric-defines.txt
  llvm/test/FileCheck/numeric-expression.txt
  llvm/test/FileCheck/opt-color.txt
  llvm/test/FileCheck/string-defines-diagnostics.txt
  llvm/test/FileCheck/string-defines.txt
  llvm/test/FileCheck/validate-check-prefix.txt
  llvm/test/FileCheck/var-scope.txt
  llvm/test/FileCheck/verbose.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65121.216111.patch
Type: text/x-patch
Size: 53526 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190820/298d3675/attachment.bin>