[PATCH] D66419: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the FDE location

Tue Aug 20 05:30:04 PDT 2019

asb marked 3 inline comments as done.
asb added inline comments.

================
Comment at: llvm/test/MC/RISCV/fde-reloc.s:12
 # RELAX-RELOC:   Section (4) .rela.eh_frame {
-# RELAX-RELOC-NEXT:   0x1C R_RISCV_ADD32 - 0x0
-# RELAX-RELOC-NEXT:   0x1C R_RISCV_SUB32 - 0x0
+# RELAX-RELOC-NEXT:   0x1C R_RISCV_32_PCREL - 0x0
 # RELAX-RELOC-NEXT:   0x20 R_RISCV_ADD32 - 0x0
----------------
luismarques wrote:
> The issue doesn't seem to be specific to this patch, but when you insert instructions before `.cfi_startproc` the relocation doesn't seem to be updated correctly, unlike with binutils. Might be worth looking where `EmitPersonality` gets its `Symbol` from.
I had a look and actually couldn't reproduce this issue when using GNU readelf -r on both llvm-mc and GNU as output.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66419/new/

https://reviews.llvm.org/D66419