[PATCH] D65933: [X86] Making X86OptimizeLEAs pass public. NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 03:07:21 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - you just need to clang-format X86OptimizeLEAs.cpp as the addition of "X86" has screwed up indentations.



================
Comment at: llvm/lib/Target/X86/X86OptimizeLEAs.cpp:311
+int X86OptimizeLEAPass::calcInstrDist(const MachineInstr &First,
                                    const MachineInstr &Last) {
   // Both instructions must be in the same basic block and they must be
----------------
clang-format


================
Comment at: llvm/lib/Target/X86/X86OptimizeLEAs.cpp:393
                                           const MachineInstr &MI2,
                                           unsigned N2) const {
   const MachineOperand &Op1 = MI1.getOperand(N1 + X86::AddrDisp);
----------------
clang-format


================
Comment at: llvm/lib/Target/X86/X86OptimizeLEAs.cpp:417
                                     const MachineInstr &Last,
                                     int64_t &AddrDispShift) const {
   assert(isLEA(First) && isLEA(Last) &&
----------------
clang-format


================
Comment at: llvm/lib/Target/X86/X86OptimizeLEAs.cpp:570
                                                  unsigned VReg,
                                                  int64_t AddrDispShift) {
   DIExpression *Expr = const_cast<DIExpression *>(MI.getDebugExpression());
----------------
clang-format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65933/new/

https://reviews.llvm.org/D65933





More information about the llvm-commits mailing list