[PATCH] D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3]

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:134
+      assert(CurrentIndex < Mappings.size());
+      return *llvm::find_if(seq(CurrentIndex + 1, (uint64_t)Mappings.size()),
+                            [this](uint64_t Index) {
----------------
abrachet wrote:
> jhenderson wrote:
> > Maybe the cast indicates that these indexes should be size_t everywhere, since they're indexes into a container? What do you think?
> Sounds good. I have changed to `size_t` it does make more sense.
`uint64_t -> size_t` change should be made to Part 1 D64281.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65633/new/

https://reviews.llvm.org/D65633