[PATCH] D66431: [PDB] Fix bug when using multiple PCH header objects with the same name.

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: lld/test/COFF/precomp-link-samename.test:1
+RUN: lld-link %S/Inputs/precompb/useprecomp.obj %S/Inputs/precompa/precomp.obj %S/Inputs/precompb/precomp.obj \
+RUN:     %S/Inputs/precompa/useprecomp.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe  \
----------------
zturner wrote:
> Note the order of object files here.  It's important.
> 
> b/useprecomp -> a/precomp.
> 
> This means that when searching the list of input files for b/useprecomp, it will find a/precomp first, and since the filename 'precomp.obj' matches, the existing code would have found it, whereas the new code actually checks matches against `precompa/precomp.obj` , which won't match.
Could you please add this as a comment at the top of the test file?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66431/new/

https://reviews.llvm.org/D66431