[PATCH] D62875: [GWP-ASan] Add public-facing documentation [6].
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 16:57:36 PDT 2019
morehouse accepted this revision.
morehouse added inline comments.
================
Comment at: llvm/docs/GwpAsan.rst:138
+ ``-GWP_ASAN_DEFAULT_OPTIONS="..."`` when building
+ ``optional/options_parser.cpp``).
+
----------------
hctim wrote:
> morehouse wrote:
> > Do we expect/want-to-support building outside of compiler-rt? If we encourage this, we may end up with many forks of GWP-ASan.
> I think that supporting out-of-RT builds is necessary. We've got an Android repository slice up and going that will definitely be out-of-tree builds.
>
> My goal is basically to have the core `**/*.h` and `**/*.cpp`. If you want to use GWP-ASan, simply pull in the slice of the repository and add it to your build.
>
> Maybe I should copybara slice this out of CRT and keep a makefile-independent (read: only cpp and header files) version so that it can be mirrored everywhere... WDYT?
Not sure if we have a need/demand for this. I'm inclined to not do this unless we have a good reason.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62875/new/
https://reviews.llvm.org/D62875
More information about the llvm-commits
mailing list