[PATCH] D66441: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: Whitney, anhtuyen, pree-jackie.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

rL367756 <https://reviews.llvm.org/rL367756> (f5c40cb <https://reviews.llvm.org/rGf5c40cb9002a7cbddec66dc4b440525ae1f14751>) increases the dependency of LLVMOrcJIT on LLVMPasses.  In particular, symbols defined in LLVMPasses that are referenced by the destructor of `PassBuilder` are now referenced by LLVMOrcJIT through `Speculation.cpp.o`.

We believe that referencing symbols defined in LLVMPasses in the destructor of `PassBuilder` is valid, and that adding to the set of such symbols is legitimate. To support such cases, this patch adds LLVMPasses to the set of libraries being linked when linking in LLVMOrcJIT causes such symbols from LLVMPasses to be referenced.


Repository:
  rL LLVM

https://reviews.llvm.org/D66441

Files:
  lib/ExecutionEngine/Orc/CMakeLists.txt
  tools/lli/CMakeLists.txt
  unittests/ExecutionEngine/Orc/CMakeLists.txt


Index: unittests/ExecutionEngine/Orc/CMakeLists.txt
===================================================================
--- unittests/ExecutionEngine/Orc/CMakeLists.txt
+++ unittests/ExecutionEngine/Orc/CMakeLists.txt
@@ -4,6 +4,7 @@
   ExecutionEngine
   Object
   OrcJIT
+  Passes
   RuntimeDyld
   Support
   native
Index: tools/lli/CMakeLists.txt
===================================================================
--- tools/lli/CMakeLists.txt
+++ tools/lli/CMakeLists.txt
@@ -12,6 +12,7 @@
   MCJIT
   Object
   OrcJIT
+  Passes
   RuntimeDyld
   SelectionDAG
   Support
Index: lib/ExecutionEngine/Orc/CMakeLists.txt
===================================================================
--- lib/ExecutionEngine/Orc/CMakeLists.txt
+++ lib/ExecutionEngine/Orc/CMakeLists.txt
@@ -35,4 +35,5 @@
   LLVMAnalysis
   LLVMBitReader
   LLVMBitWriter
+  LLVMPasses
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66441.215984.patch
Type: text/x-patch
Size: 863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190819/ce2da2f4/attachment.bin>