[PATCH] D66431: [PDB] Fix bug when using multiple PCH header objects with the same name.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Looks fine to me, but let @aganea comment since he's looked at this more than I have.



================
Comment at: lld/COFF/PDB.cpp:521
+static ObjFile *findObjByName(StringRef filePath) {
   for (ObjFile *f : ObjFile::instances) {
+    if (equals_path(filePath, f->getName()))
----------------
Erg, this is obviously quadratic in input objects. Whatever, it's not your problem, either it shows up in the profile or it doesn't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66431/new/

https://reviews.llvm.org/D66431