[PATCH] D64869: [SCEV] get more accurate range for AddExpr with NW flag

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 13:59:18 PDT 2019


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5575
+        WrapType = OBO::NoSignedWrap;
+      else if (Add->hasNoUnsignedWrap() &&
+               SignHint == ScalarEvolution::HINT_RANGE_UNSIGNED)
----------------
Move this if/else chain outside the loop.  It's loop invariant, and confusing (but correct) as written.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64869/new/

https://reviews.llvm.org/D64869





More information about the llvm-commits mailing list