[PATCH] D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass.

Mon Aug 19 12:11:01 PDT 2019

dstenb added a comment.

(A bit related to aprantl's latest comment.)

Would it be possible to add (or perhaps better, adapt one of the attached test cases into) single-pass tests? I personally think that would make it a bit easier to see what's going in.

================
Comment at: llvm/test/DebugInfo/X86/sroa-after-inlining2.ll:189-191
+!41 = !DILocation(line: 24, column: 5, scope: !7)
+!42 = !DILocation(line: 24, column: 10, scope: !7)
+!43 = !DILocation(line: 24, column: 24, scope: !7)
----------------
Can the different column entries be merged into one entry? That would increase the SNR of the test case.

(For future reference: Clang can omit column information when passed -gno-column-info.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64595/new/

https://reviews.llvm.org/D64595