[PATCH] D66391: [Sanitizer] arc4random interception on Mac

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 09:57:06 PDT 2019


devnexen added a comment.

In D66391#1635532 <https://reviews.llvm.org/D66391#1635532>, @yln wrote:

> I am not sure, but should we now call `REAL(arc...)` below?
>
> compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp:1180:
>
>   bool GetRandom(void *buffer, uptr length, bool blocking) {
>     if (!buffer || !length || length > 256)
>       return false;
>     // arc4random never fails.
>     arc4random_buf(buffer, length);
>     return true;
>   }
>


yes indeed.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66391/new/

https://reviews.llvm.org/D66391





More information about the llvm-commits mailing list