[PATCH] D66291: [test/Object] - Move/rewrite 2 more test cases.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 03:07:47 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-reloc-no-sym.test:25
+      - Offset: 0x12345678
+        Type:   R_X86_64_IRELATIVE
+        Addend: 0x87654321
----------------
jhenderson wrote:
> Maybe worth making this R_X86_64_NONE too? Doesn't really matter though.
Using different relocation types (not all R_*_NONE) adds some variety..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66291/new/

https://reviews.llvm.org/D66291





More information about the llvm-commits mailing list