[PATCH] D66128: [Attributor] Use structured deduction for AANonNull

[Hideto Ueno via Phabricator via llvm-commits]

uenoku accepted this revision.
uenoku added a comment.
This revision is now accepted and ready to land.

I think we need a test for `nonnull` floating value (also for `dereferenceable`) once on-demand creation merged.
I added some comments but it seems to me that these will be resolved in D66276 <https://reviews.llvm.org/D66276> :). Therefore, it looks good to me.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1256-1260
+    // TODO: This context sensitive query should be removed once we can do
+    // context sensitive queries in the genericValueTraversal below.
+    if (isKnownNonZero(&V, DL, 0, /* TODO: AC */ nullptr, IRP.getCtxI(),
+                       /* TODO: DT */ nullptr))
+      return ChangeStatus::UNCHANGED;
----------------
I think it should be in `initialize`.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1272
+        if (!AA->isAssumedNonNull())
+          T.indicateOptimisticFixpoint();
+      } else {
----------------
Is `optimistic` correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66128/new/

https://reviews.llvm.org/D66128