[PATCH] D66371: [CaptureTracker] Let subclasses provide dereferenceability information

[Ayke via Phabricator via llvm-commits]

aykevl accepted this revision.
aykevl added a comment.
This revision is now accepted and ready to land.

LGTM from my perspective but I'm not a C++ person so can't comment on style etc.

Off-topic: really happy to see your work on the Attributor. The nocapture flag is very important to avoid heap allocations in the compiler I'm working on.



================
Comment at: llvm/lib/Analysis/CaptureTracking.cpp:39
+  // or to the end of an allocation), or be null in the default
+  // address space. So for an inbounds GEPs there is no way to let
+  // the pointer escape using clever GEP hacking because doing so
----------------
Nit: I just notice that there is a typo in this sentence: "So for an inbounds GEPs...". It should be "So for an inbounds GEP..." (singular) or "So for inbounds GEPs..." (plural). But this was also in the original comment that I wrote so it's not really important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66371/new/

https://reviews.llvm.org/D66371