[PATCH] D66346: [LLD][ELF][ARM] Add a test that maxes out the thunk convergence limit

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 17 02:25:28 PDT 2019


grimar added a comment.

Looks good. 2 questions are inline.



================
Comment at: lld/test/ELF/arm-thunk-many-passes.s:26
+// CHECK-SYM:     Name: sym
+// CHECK-SYM-NEXT:     Value: 0x101104C
+
----------------
Does it make sense to show that `.text` output section has size == 0x100004C (it seems)?


================
Comment at: lld/test/ELF/arm-thunk-many-passes.s:103
+        nop
+        .thumb_func
----------------
The last line with `.thumb_func` seems excessive?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66346/new/

https://reviews.llvm.org/D66346





More information about the llvm-commits mailing list