[PATCH] D65983: Autogenerate the shebang lines for tools/opt-viewer

Christian Biesinger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 15:37:44 PDT 2019


cbiesinger updated this revision to Diff 215696.
cbiesinger added a comment.

Use python's basename


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65983/new/

https://reviews.llvm.org/D65983

Files:
  llvm/CMakeLists.txt
  llvm/tools/opt-viewer/CMakeLists.txt
  llvm/tools/opt-viewer/opt-diff.py
  llvm/tools/opt-viewer/opt-diff.py.in
  llvm/tools/opt-viewer/opt-stats.py
  llvm/tools/opt-viewer/opt-stats.py.in
  llvm/tools/opt-viewer/opt-viewer.py
  llvm/tools/opt-viewer/opt-viewer.py.in
  llvm/tools/opt-viewer/optrecord.py
  llvm/tools/opt-viewer/optrecord.py.in


Index: llvm/tools/opt-viewer/optrecord.py.in
===================================================================
--- llvm/tools/opt-viewer/optrecord.py.in
+++ llvm/tools/opt-viewer/optrecord.py.in
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env @PYTHON_BASENAME@
 
 from __future__ import print_function
 
Index: llvm/tools/opt-viewer/opt-viewer.py.in
===================================================================
--- llvm/tools/opt-viewer/opt-viewer.py.in
+++ llvm/tools/opt-viewer/opt-viewer.py.in
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env @PYTHON_BASENAME@
 
 from __future__ import print_function
 
Index: llvm/tools/opt-viewer/opt-stats.py.in
===================================================================
--- llvm/tools/opt-viewer/opt-stats.py.in
+++ llvm/tools/opt-viewer/opt-stats.py.in
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env @PYTHON_BASENAME@
 
 from __future__ import print_function
 
Index: llvm/tools/opt-viewer/opt-diff.py.in
===================================================================
--- llvm/tools/opt-viewer/opt-diff.py.in
+++ llvm/tools/opt-viewer/opt-diff.py.in
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env @PYTHON_BASENAME@
 
 from __future__ import print_function
 
Index: llvm/tools/opt-viewer/CMakeLists.txt
===================================================================
--- llvm/tools/opt-viewer/CMakeLists.txt
+++ llvm/tools/opt-viewer/CMakeLists.txt
@@ -1,13 +1,28 @@
 set (files
+  "optpmap.py"
+  "style.css")
+
+set (generated_files
   "opt-diff.py"
   "opt-stats.py"
   "opt-viewer.py"
-  "optpmap.py"
-  "optrecord.py"
-  "style.css")
+  "optrecord.py")
+
+foreach (file ${generated_files})
+  configure_file(
+    ${CMAKE_CURRENT_SOURCE_DIR}/${file}.in
+    ${CMAKE_CURRENT_BINARY_DIR}/${file})
+endforeach (file)
 
 foreach (file ${files})
   install(PROGRAMS ${file}
     DESTINATION share/opt-viewer
     COMPONENT opt-viewer)
 endforeach (file)
+
+
+foreach (file ${generated_files})
+  install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${file}
+    DESTINATION share/opt-viewer
+    COMPONENT opt-viewer)
+endforeach (file)
Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -660,6 +660,8 @@
   message(FATAL_ERROR "Python 2.7 or newer is required")
 endif()
 
+get_filename_component(PYTHON_BASENAME ${PYTHON_EXECUTABLE} NAME)
+
 ######
 # LLVMBuild Integration
 #


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65983.215696.patch
Type: text/x-patch
Size: 2463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190816/144bec18/attachment.bin>


More information about the llvm-commits mailing list