[PATCH] D66330: Fix use-after-free in CodeGenPrepare

[Brent Royal-Gordon via Phabricator via llvm-commits]

brentdax marked an inline comment as done.
brentdax added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7019
 
   // TODO: Move this into the switch on opcode - it handles shifts already.
   if (BinOp && (BinOp->getOpcode() == Instruction::AShr ||
----------------
spatel wrote:
> Alternative to this patch: act on that TODO.
Even if I did act on the TODO, I think we would still need the fix in this patch to avoid calling optimizeShiftInst() with the freed instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66330/new/

https://reviews.llvm.org/D66330