[PATCH] D66356: [WebAssembly] Forbid use of EM_ASM with setjmp/longjmp

Guanzhong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 12:31:04 PDT 2019


quantum marked 2 inline comments as done.
quantum added inline comments.


================
Comment at: llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:555
+         Callee == EmAsmConstIntSyncMainF ||
+         Callee == EmAsmConstDoubleSyncMainF || Callee == EmAsmConstAsyncMainF;
+}
----------------
sbc100 wrote:
> Why not just compare names here?  
> 
> 
For consistency with `WebAssemblyLowerEmscriptenEHSjLj::canLongjmp`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66356/new/

https://reviews.llvm.org/D66356





More information about the llvm-commits mailing list