[PATCH] D66355: [COFF] Add libcall symbols to the link when LTO is being used.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/COFF/SymbolTable.cpp:588
+void SymbolTable::addLibcall(StringRef name) {
+  Symbol *sym = find(name);
+  if (!sym)
----------------
rnk wrote:
> pcc wrote:
> > The logic here should depend on the name. If it begins with `\01` use `find` on `name.substr(1)`, otherwise use `findUnderscore`.
> So far as I can tell, none of the symbols from RuntimeLibcalls use the `\01` escape prefix. Is that necessary? Can this be simplified to just one call to `findUnderscore`?
I vaguely recalled that we had some, but yes, apparently we don't. Simplifying to `findUnderscore` sounds good then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66355/new/

https://reviews.llvm.org/D66355