[PATCH] D66190: [CodeGen] Add a pass to do block predication on SSA machine IR

Thomas Raoux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 11:09:01 PDT 2019


ThomasRaoux marked an inline comment as done.
ThomasRaoux added inline comments.


================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:982
+/// Update the dominator tree after if-conversion erased some blocks.
+void EarlyIfPredicator::updateDomTree(ArrayRef<MachineBasicBlock *> Removed) {
+  // convertIf can remove TBB, FBB, and Tail can be merged into Head.
----------------
jmolloy wrote:
> This looks stateless with respect to DomTree and Removed; we should share this between the two implementations.
Fixed it by moving it to functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66190/new/

https://reviews.llvm.org/D66190





More information about the llvm-commits mailing list