[PATCH] D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass.

[Alexey Lapshin via Phabricator via llvm-commits]

avl updated this revision to Diff 215628.
avl added a comment.

I implemented the solution which avoids lowering dbg.declare for structures. Please check updated patch. Note, I marked two tests as XFAIL since they check for lowering which is not done with this patch. Though it looks to me that it would be better to make dbg.addr to work. I am thinking of changing LowerDbgDeclare in such a way that it would produce dbg.addr and dbg.value instead of dbg.value only. i.e. dbg.addr would be generated for cases when dbg.value with memory operand is generated currently...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64595/new/

https://reviews.llvm.org/D64595

Files:
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/DebugInfo/X86/sroa-after-inlining.ll
  llvm/test/DebugInfo/X86/sroa-after-inlining2.ll
  llvm/test/Transforms/InstCombine/lower-dbg-declare.ll
  llvm/test/Transforms/Util/simplify-dbg-declare-load.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64595.215628.patch
Type: text/x-patch
Size: 23074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190816/5c5d0ed7/attachment.bin>