[PATCH] D66346: [LLD][ELF][ARM] Add a test that maxes out the thunk convergence limit

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 09:17:26 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/ELF/arm-thunk-many-passes.s:12
+
+// A worst case case of thunk generation that takes 9 passes to converge
+// one fewer than the limit of 10.
----------------
> one fewer than the limit of 10.

It takes 9 passes to create all thunks. An extra createThunks is called to check no address changes, so createThunks is actually called 10 times. (The 11th call of createThunks will error.)

I think the comment can be improved a bit but I am not sure how to reword it to make it clearer...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66346/new/

https://reviews.llvm.org/D66346





More information about the llvm-commits mailing list