[PATCH] D65497: [RISCV] Avoid generating AssertZext for LP64 ABI when lowering floating Libcall

[Luís Marques via Phabricator via llvm-commits]

luismarques added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:3560
     bool IsPostTypeLegalization : 1;
+    SDNode *NodeBeforeSoften = nullptr;
 
----------------
This new field makes the parent struct a bit misnamed, and something about this approach of passing the node in the options smells a bit to me, but I couldn't come up with a better alternative. Also, for alignment purposes it's probably better to put the SDNode pointer before the flags.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:137
     Entry.Ty = Entry.Node.getValueType().getTypeForEVT(*DAG.getContext());
-    Entry.IsSExt = shouldSignExtendTypeInLibCall(Op.getValueType(),
+    Entry.IsSExt = shouldSignExtendTypeInLibCall(NewOp.getValueType(),
                                                  CallOptions.IsSExt);
----------------
No point in calling `shouldSignExtendTypeInLibCall` if `shouldExt` is false. Refactor the flow?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65497/new/

https://reviews.llvm.org/D65497