[PATCH] D39323: [lld] Support dynamic linking in RISC-V

Thu Aug 15 03:14:29 PDT 2019

MaskRay closed this revision.
MaskRay added a comment.

In D39323#1631117 <https://reviews.llvm.org/D39323#1631117>, @lenary wrote:

> Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Yes, the functionality has already been upstreamed. I somehow forgot this one while I was doing that... Mainly D63076 <https://reviews.llvm.org/D63076> (GOT,PLT,COPY,relative), D63220 <https://reviews.llvm.org/D63220> (TLS) and a few other fixups.
The functionality should be pretty complete in the llvm 9 release: I built libc-test against glibc riscv64 and musl riscv64.

R_RISCV_RELAX/R_RISCV_ALIGN has not been implemented. There is some technical difficulty - shrinkable sections do not fit in lld's current framework. It can be implemented but generally I think R_RISCV_RELAX can have other problems... e.g. it breaks split dwarf, it disallows section symbols in object files, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39323/new/

https://reviews.llvm.org/D39323