[PATCH] D66010: [ARM] MVE sext costs

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard requested changes to this revision.
ostannard added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:346
 
+  static const TypeConversionCostTblEntry MVEVectorConversionTbl[] = {
+    { ISD::SIGN_EXTEND, MVT::v8i16, MVT::v8i8, 1 },
----------------
I think this could do with a comment explaining where the numbers come from. If it's based on the current assembly we generate, are we already generating the optimal sequences, or would these numbers need to change as our code-gen improves?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66010/new/

https://reviews.llvm.org/D66010