[PATCH] D66285: [ARM] Correct register for narrowing and widening MVE loads and stores.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 04:14:29 PDT 2019


dmgreen marked an inline comment as done.
dmgreen added a comment.

Thanks for taking a look



================
Comment at: llvm/lib/Target/ARM/Thumb2InstrInfo.cpp:656
+    if ((unsigned)Offset <= Mask * Scale &&
+        (Register::isVirtualRegister(FrameReg) ||
+         RegClass->contains(FrameReg))) {
----------------
ostannard wrote:
> Is it possible to get here with a virtual register of the wrong class? I think we'd need a call to `constrainRegClass` here in that case.
Hmm, I have not seen us hit this, but it's certainly better to be safe than sorry! I'll add a check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66285/new/

https://reviews.llvm.org/D66285





More information about the llvm-commits mailing list