[PATCH] D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 03:41:36 PDT 2019


MaskRay added inline comments.


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:392
   handleAllErrors(createFileError(Input, std::move(Err)),
-                  [&](const ErrorInfoBase &EI) { reportError(EI.message()); });
+                  [&](const ErrorInfoBase &EI) { error(EI.message()); });
 }
----------------
`llvm_unreachable` after handleAllErrors. handleAllErrors is not marked noreturn, so it needs manual annotation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66286/new/

https://reviews.llvm.org/D66286





More information about the llvm-commits mailing list