[PATCH] D62875: [GWP-ASan] Add public-facing documentation [6].

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 17:08:24 PDT 2019


hctim added inline comments.


================
Comment at: llvm/docs/GwpAsan.rst:136
+- At compile time, by defining ``GWP_ASAN_DEFAULT_OPTIONS`` to the options
+  string you want set by default;
+
----------------
morehouse wrote:
> morehouse wrote:
> > Is this a CMake variable, a preprocessor macro, or something else?
> This helps, but it's still not clear whether this is a cmake variable or a preprocessor variable.
> 
> Do I do this with:
> ```
> cmake ... -DGWP_ASAN_DEFAULT_OPTIONS="..."
> ```
> or
> ```
> clang++ -fsanitize=scudo ... -DGWP_ASAN_DEFAULT_OPTIONS="..."
> ```
Added some clarifying comments, let me know if they LGTY.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62875/new/

https://reviews.llvm.org/D62875





More information about the llvm-commits mailing list