[PATCH] D66167: MemTag: stack initializer merging.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 16:31:08 PDT 2019


pcc added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:196
+      if (Offset > LastOffset)
+        emitZeroes(IRB, LastOffset, Offset - LastOffset);
+
----------------
This could call `emitUndef`, right? Is there an advantage in using `STZG` instead of `STG` here, and if so, should we be doing the same thing on line 181?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66167/new/

https://reviews.llvm.org/D66167





More information about the llvm-commits mailing list