[PATCH] D66318: [SDAG] Update generic code to conservatively check for isAtomic in addition to isVolatile

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 16:09:47 PDT 2019


reames created this revision.
reames added reviewers: jlebar, jfb, craig.topper, RKSimon, efriedma.
Herald added subscribers: dexonsmith, bollu, mcrosier.
Herald added a project: LLVM.

See D66309 <https://reviews.llvm.org/D66309> for context.

This is the first sweep of generic code to add isAtomic bailouts where appropriate.  The intention here is to have the switch from AtomicSDNode to LoadSDNode/StoreSDNode be close to NFC; that is, I'm not looking to allow additional optimizations at this time.  That will come later.

(Note: This is currently based on ToT without D66309 <https://reviews.llvm.org/D66309>.  That's why there are no test diffs with the experimental flag visible.  It could be added either before or after that change.)


Repository:
  rL LLVM

https://reviews.llvm.org/D66318

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/TargetLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66318.215489.patch
Type: text/x-patch
Size: 18953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190815/032ea6fc/attachment.bin>


More information about the llvm-commits mailing list