[PATCH] D66280: [llvm-objcopy][MachO] Support indirect symbol table

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 14:05:11 PDT 2019


rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOReader.cpp:261-263
+    if (Index == MachO::INDIRECT_SYMBOL_LOCAL ||
+        Index == MachO::INDIRECT_SYMBOL_ABS ||
+        Index == (MachO::INDIRECT_SYMBOL_LOCAL | MachO::INDIRECT_SYMBOL_ABS))
----------------
Can this be simplified to a bitmask check? e.g.:

```
if (Index & (MachO::INDIRECT_SYMBOL_LOCAL | MachO::INDIRECT_SYMBOL_ABS) != 0)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66280/new/

https://reviews.llvm.org/D66280





More information about the llvm-commits mailing list