[PATCH] D66310: Fix nm on GCC 5.1 after the C++14 move

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 13:32:21 PDT 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks again!



================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:717
+                         ? &compareSymbolAddress
+                         : (SizeSort ? &compareSymbolSize : &compareSymbolName);
 
----------------
Nit: I find the staggered if on the lhs easier to readh than the nested ternary


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66310/new/

https://reviews.llvm.org/D66310





More information about the llvm-commits mailing list